Add support for Sourcify contract information lookup#1899
Merged
YaroShkvorets merged 9 commits intographprotocol:mainfrom Jan 21, 2025
Merged
Add support for Sourcify contract information lookup#1899YaroShkvorets merged 9 commits intographprotocol:mainfrom
YaroShkvorets merged 9 commits intographprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dfd7bde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0237h
force-pushed
the
feat/support-sourcify-lookups
branch
from
6464dbd to
e9206b6
Compare
- Contract name, ABI and creation transaction hash (start block) from [Sourcify API](https://docs.sourcify.dev/docs/api/). - Runs before the registry lookup and replaces default values (not interactive) if not provided by the user. This means priority for CLI parameters looks like: user submitted (env/CLI args) > Sourcify API > Default values > Registry fetch
0237h
force-pushed
the
feat/support-sourcify-lookups
branch
from
e9206b6 to
c5c9010
Compare
0237h
force-pushed
the
feat/support-sourcify-lookups
branch
from
5d4312f to
19cbd8a
Compare
YaroShkvorets
requested changes
Jan 15, 2025
Collaborator
There was a problem hiding this comment.
Looks good.
Can we add a couple of test cases to https://github.com/graphprotocol/graph-tooling/blob/main/packages/cli/src/command-helpers/contracts.test.ts
Also, any idea why it can't find source code on Sourcify for this contract on mainnet: 0xb47e3cd837dDF8e4c57F05d70Ab865de6e193BBB. It exists on Etherscan. I thought it's supposed to import it from etherscan?
0237h
force-pushed
the
feat/support-sourcify-lookups
branch
from
25fd23e to
7aa683f
Compare
YaroShkvorets
approved these changes
Jan 16, 2025
Collaborator
YaroShkvorets
left a comment
YaroShkvorets
left a comment
There was a problem hiding this comment.
LGTM
added some retry logic to etherscan tests to handle rate-limited endpoints
incrypto32
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Add support for Sourcify contract information lookup - Contract name, ABI and creation transaction hash (start block) from [Sourcify API](https://docs.sourcify.dev/docs/api/). - Runs before the registry lookup and replaces default values (not interactive) if not provided by the user. This means priority for CLI parameters looks like: user submitted (env/CLI args) > Sourcify API > Default values > Registry fetch * Fix incorrect ABI instantiation for `init` with parameters * Add changeset * Throw early for non-EVM chains * Add tests for contract name and startBlock info * Add test for non-evm contract lookup * removed hardcoded wax check, added test * add retries to tests --------- Co-authored-by: YaroShkvorets <shkvorets@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Etherscan requires an API key for ABI lookup and other operations.
Sourcify (https://sourcify.dev/) is an open-source decentralized alternative.
Features
This means priority for CLI parameters looks like:
user submitted (env/CLI args) > Sourcify API > Default values > Registry fetch
Closes #1001.
Details
The
getFromSourcifymethod returns all the information related to contracts that are normally fetch from registry URLs:It internally makes the RPC call for the
startBlockusing the creation transaction hash.